This repository was archived by the owner on Aug 4, 2021. It is now read-only.
#214 Add issue templates#217
Merged
lukastaegert merged 2 commits intoMay 10, 2019
Merged
Conversation
lukastaegert
suggested changes
May 8, 2019
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks a lot for taking care of this! Just added two things I noticed we might want to adapt.
| 👉 https://opencollective.com/rollup/donate | ||
| --> | ||
|
|
||
| - Rollup Version: |
Member
There was a problem hiding this comment.
As this is for rollup-plugin-node-resolve, the plugin version would also be very important! How about
Node-Resolve Plugin Version:
Rollup Version:
Operating System (or Browser):
Node Version:
|
|
||
|
|
||
| <!-- | ||
| Most issues can be expressed or demonstrated through the REPL or a repository. |
Member
There was a problem hiding this comment.
This does not really apply here as you do not have rollup-plugin-node-resolve in the REPL (after all, the REPL runs in the browser). Maybe we just change the first line to
<!--
Most issues can be expressed or demonstrated through a repository.
However ...
Author
There was a problem hiding this comment.
For clarity maybe Most issues can be expressed or demonstrated through a reproduction repository. However ... ?
Does it sound good in English? I don't know him very well, correct me if I suggested nonsense :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #214. Please, check, I don't know how issues templates work.