This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Support resolve 1.11.1, add built-in test#223
Merged
Conversation
lukastaegert
approved these changes
Jun 13, 2019
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks a lot, looks good to me!
This was referenced Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #222.
I wasn't sure why the test was disabled, possibly due to needing to pass in require. Happy to remove the test if it's not needed.
Confirmed tests and linters pass (and confirmed there were a number of test failures with resolve 1.11.1). Once exception: the symlink tests don't seem to run on Windows, but I doubt this change would impact them.