New showDiff behaviour also depending on expected and actual values#574
Merged
Merged
Conversation
Member
|
Thanks for the awesome work @lucasfcosta 😄 |
keithamus
added a commit
that referenced
this pull request
Dec 20, 2015
New showDiff behaviour also depending on expected and actual values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the #515 issue.
I've used try/catch blocks on the test because adding a new parameter to the
err()function seems too ugly.I'm also directly using chai.Assertion because this way we guarantee this test won't be too tightly coupled with other assertion methods implementation.
PS.: Thank you guys for the awesome work you've been doing on Chai.