Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serves static content from docs.python.org. #65

Merged
merged 2 commits into from Nov 2, 2016
Merged

Serves static content from docs.python.org. #65

merged 2 commits into from Nov 2, 2016

Conversation

@lisroach
Copy link

@lisroach lisroach commented Oct 17, 2016

Except for the collapsible sidebar, which requires a change in Sphinx iteself.

Also changed hover color for header links.
Lisa Roach
Serves static content from docs.python.org.
7dc1131 
Except for the collapsible sidebar, which requires a change in Sphinx iteself.

Also changed hover color for header links.
@lisroach lisroach mentioned this pull request Oct 17, 2016
Closed
@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Oct 17, 2016

Sorry for the delay. I'm reviewing this now.
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 28, 2016

@berkerpeksag is your review done? Otherwise I'm tempted to accept this PR as-is.
@zware
Use a simpler color for navbar link hover
6ff869c
@zware zware merged commit 9578fb7 into python:master Nov 2, 2016
@lisroach lisroach deleted the lisroach:theme-update branch Nov 2, 2016
@lisroach
Copy link
Author

@lisroach lisroach commented Nov 2, 2016

Thank you!
@zware
Copy link
Member

@zware zware commented Nov 2, 2016

Thanks, @lisroach! I changed the hover color to #eee, otherwise the patch was great.
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 2, 2016

We should probably either do a merge into github or do a cherry pick.
@zware
Copy link
Member

@zware zware commented Nov 2, 2016

Should already be done. There were also a few other outstanding changes on master that were also merged.
@willingc
Copy link
Collaborator

@willingc willingc commented Nov 3, 2016

Thanks @zware for the work on merging the outstanding changes on master 😄 I've been slammed with Jupyter stuff lately. Thanks @brettcannon for keeping this on your radar 🎯 😄

@lisroach Congrats! Thanks and great to see this merged: 🎉
@willingc willingc mentioned this pull request Nov 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@lisroach @berkerpeksag @brettcannon @zware @willingc @the-knights-who-say-ni
You can’t perform that action at this time.