Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenWebSite image for View/Open on GitHub #1877

Merged
merged 3 commits into from Aug 29, 2018

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Aug 23, 2018

Breaking up commits from #1561 into separate PRs...

What this PR does

The GitHub logo is currently overloaded for different commands. This PR changes the View/Open on GitHub to use the standard OpenWebSite image.

  • Use OpenWebSite image for View/Open on GitHub

Before
image

After
image

Copy link
Member

@donokuda donokuda left a comment

🙇

The GitHub logo is currently overloaded for different commands. This PR changes the View/Open on GitHub to use the standard OpenWebSite image.

Definitely agree on the GitHub mark being overloaded with different commands. 👍 We might want to decide on a single command for the GitHub mark, or try to avoid using it as a command icon in general.

Thanks Jamie!

@jcansdale jcansdale requested review from tinaschrepfer and removed request for tinaschrepfer Aug 28, 2018
@jcansdale jcansdale merged commit c4474f0 into master Aug 29, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jcansdale jcansdale deleted the jcansdale/OpenWebSite-image-ViewOnGitHub branch Aug 29, 2018
@meaghanlewis meaghanlewis added this to the 2.5.6 milestone Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.