Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted the todo entries #423

Merged
merged 4 commits into from Nov 15, 2018
Merged

Sorted the todo entries #423

merged 4 commits into from Nov 15, 2018

Conversation

@Seluj78
Copy link
Collaborator

Seluj78 commented Nov 14, 2018

No description provided.

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 14, 2018

@JulienPalard
Copy link
Member

JulienPalard commented Nov 15, 2018

Je pense que tu peux merger le ".sh" dans le ".py" en utilisant le module glob.

Ensuite les dossier au lieu de les hardcoder tu peux les découvrir aisément:

>>> {Path(po_file).parent for po_file in glob("**/*.po")}
{PosixPath('extending'), PosixPath('reference'), PosixPath('whatsnew'), PosixPath('howto'), PosixPath('using'), PosixPath('tutorial'), PosixPath('c-api'), PosixPath('distutils'), PosixPath('faq'), PosixPath('library'), PosixPath('install'), PosixPath('distributing'), PosixPath('installing')}

Tu pourrais calculer un total par dossier aussi, et si tu es motivé, un pourcentage de progression par dossier ^^

Bonus ultime: Se passer de msgattrib, car tout le monde ne l'a pas, et donc tout le monde ne peut pas faire un make todo :( T'es peut être pas obligé de te passer de polib pour ça, si l'import de polib foire tu peux mettre un joli message comme quoi il faut installer polib peut être ?

@JulienPalard JulienPalard merged commit 3cb3ca3 into python:3.7 Nov 15, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JulienPalard
Copy link
Member

JulienPalard commented Nov 15, 2018

We replaced a single bash line by 55 Python lines \o/

@Seluj78 Seluj78 deleted the Seluj78:sorted-make-todo branch Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.