Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-2504: Add pgettext() and variants to gettext #7253

Merged
merged 7 commits into from Nov 7, 2018
Merged

bpo-2504: Add pgettext() and variants to gettext #7253

merged 7 commits into from Nov 7, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented May 30, 2018 •
edited by bedevere-bot

Original patch by Franz Glasner.

https://bugs.python.org/issue2504

serhiy-storchaka
serhiy-storchaka reviewed May 31, 2018
View changes
Doc/library/gettext.rst Outdated Show resolved Hide resolved
@damufo
Copy link

damufo commented Oct 26, 2018

Hello:
How is this?
I think it would be interesting to complete it.
Being able to use context in gettext would allow for example to specify the gender.

serhiy-storchaka
serhiy-storchaka requested changes Oct 27, 2018
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Remove l*gettext() functions and fix the documentation.

@bedevere-bot
Copy link

bedevere-bot commented Oct 27, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor Author

csabella commented Oct 28, 2018

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Oct 28, 2018

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Oct 29, 2018
View changes
Doc/library/gettext.rst Outdated Show resolved Hide resolved
Doc/library/gettext.rst Outdated Show resolved Hide resolved
Lib/gettext.py Outdated Show resolved Hide resolved
Tools/i18n/msgfmt.py Outdated Show resolved Hide resolved
Tools/i18n/msgfmt.py Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Oct 29, 2018
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 29, 2018

Please add also a What's New entry.

serhiy-storchaka
serhiy-storchaka reviewed Nov 2, 2018
View changes
Doc/library/gettext.rst Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed Nov 2, 2018
View changes
Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved
merwok
merwok approved these changes Nov 4, 2018
View changes
@serhiy-storchaka serhiy-storchaka merged commit 637a33b into python:master Nov 7, 2018
@csabella csabella deleted the bpo2504 branch Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@csabella @damufo @bedevere-bot @serhiy-storchaka @merwok @the-knights-who-say-ni