Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-35683: Improve Azure Pipelines steps #11493
Conversation
zooba
added
OS-windows
DO-NOT-MERGE
labels
Jan 10, 2019
the-knights-who-say-ni
added
the
CLA signed
label
Jan 10, 2019
bedevere-bot
added
the
awaiting merge
label
Jan 10, 2019
zooba
added some commits
Jan 10, 2019
zooba
requested review from
terryjreedy
and
python/windows-team
as
code owners
Jan 17, 2019
zooba
added some commits
Jan 17, 2019
zooba
removed
the
DO-NOT-MERGE
label
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
|
The full APPX test was only in the PR build for testing. The idea is to run it against commits only to avoid adding extra time to PRs while still having a way to check whether we've broken various parts of the distro. For anyone who doesn't know, you can view CI build status at https://github.com/python/cpython/commits/master (including all the buildbots :) ) |
zooba
changed the title
bpo-35683: Improve Azure Pipelines steps and enable manylinux1 builds
bpo-35683: Improve Azure Pipelines steps
Jan 17, 2019
zooba
merged commit 28f6cb3
into
python:master
Jan 22, 2019
5 checks passed
bedevere-bot
removed
the
awaiting merge
label
Jan 22, 2019
zooba
deleted the
zooba:bpo-35683
branch
Jan 22, 2019
zooba
added
the
needs backport to 3.7
label
Jan 22, 2019
This comment has been minimized.
This comment has been minimized.
reaperhulk
commented
Jan 22, 2019
|
I was just pointed at this and I thought it might be worth mentioning that we updated the |
This comment has been minimized.
This comment has been minimized.
|
@reaperhulk Not at all, since the container isn't actually suitable for our needs anyway (nor was the previous one in the build files, which is why I left it referenced). We probably need to set up our own container with the right dependencies for building and testing CPython itself - the base definition for manylinux containers goes past this point, so any derived ones are going to be missing things. They're fine for building binaries (I assume), but not for running our entire test suite. |
added a commit
to zooba/cpython
that referenced
this pull request
Jan 22, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 22, 2019
|
GH-11651 is a backport of this pull request to the 3.7 branch. |
bedevere-bot
removed
the
needs backport to 3.7
label
Jan 22, 2019
added a commit
that referenced
this pull request
Jan 22, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 22, 2019
|
This comment has been minimized.
This comment has been minimized.
|
This is a false positive/race condition, a re-run is successful: https://buildbot.python.org/all/#/builders/116/builds/993 Something in
|
This comment has been minimized.
This comment has been minimized.
|
Yeah, the standard manylinux image intentionally deletes some libraries that cpython needs to build (because we don't want the particular versions we used to accidentally become something package maintainers depending on). |
zooba commentedJan 10, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue35683