Re-design psnr.py code and change image names#592
Merged
harshildarji merged 2 commits intoTheAlgorithms:masterfrom Nov 5, 2018
Merged
Re-design psnr.py code and change image names#592harshildarji merged 2 commits intoTheAlgorithms:masterfrom
harshildarji merged 2 commits intoTheAlgorithms:masterfrom
Conversation
… both methods). Also Added new example.
harshildarji
requested changes
Nov 3, 2018
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| main() |
Member
There was a problem hiding this comment.
Hello @rafagarciac,
I would be happy to merge this PR, but I want you to remove one of the PSNR methods and keep the only one which works better! Also, Do not forget to modify your code with respect to changes that will happen after removing the method!
Thank you.
Member
Author
There was a problem hiding this comment.
Solved ! Also I reformat some code from arithmetic_analysis 👍 💯
057291f
Member
Author
|
@harshildarji Done, take a look to the latest commit :) 057291f |
harshildarji
approved these changes
Nov 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I preserved the old algorithm which I don't know if is working as expected or not because, both methods return a different values.
But according the Wikipedia Example: https://en.wikipedia.org/wiki/Peak_signal-to-noise_ratio
The first one method will be the correct one. 👍