Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39114: Fix tracing of except handlers with name binding #17769
Conversation
This comment has been minimized.
This comment has been minimized.
|
@nedbat Can you confirm if this fixes your issue? |
This comment has been minimized.
This comment has been minimized.
|
@markshannon Can you check if this looks right to you? I am not completely sure what was the original purpose of this code (not sure what the comment |
This comment has been minimized.
This comment has been minimized.
|
@pablogsal Thanks, I'll take a look at it. Right now, this change is failing other tests of mine. We should talk about how to add more regression tests to the Python test suite so that we don't have to have these kinds of bug reports in the first place. As an example, shouldn't this pull request add some tests to confirm the fix? |
This comment has been minimized.
This comment has been minimized.
|
@pablogsal good news: looks like the coverage.py tests that fail with this change are testing the same things that the current test failure here is testing. |
This comment has been minimized.
This comment has been minimized.
Yes, but for now I am not sure that the fix is even correct so I still didn't make tests for it :) |
pablogsal commentedDec 31, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue39114