bpo-29963: Remove obsolete declaration in tokenizer.h#962
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Apr 3, 2017
DimitrisJim:remove_obsolete_decl
Merged
bpo-29963: Remove obsolete declaration in tokenizer.h#962serhiy-storchaka merged 1 commit intopython:masterfrom DimitrisJim:remove_obsolete_decl
serhiy-storchaka merged 1 commit intopython:masterfrom
DimitrisJim:remove_obsolete_decl
Conversation
|
@DimitrisJim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @serhiy-storchaka and @nascheme to be potential reviewers. |
serhiy-storchaka
approved these changes
Apr 2, 2017
Contributor
Author
|
Travis doc build failed with an |
Member
|
Triggered rebuilding. |
Contributor
Author
|
Great, thanks Serhiy! |
Contributor
Author
|
Same situation, I can't seem to understand why this is caused, docs build ok locally for me even with Update: We'll need to wait until sphinx-doc/sphinx/issues/3597 is addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couldn't trace exactly when
PyTokenizer_RestoreEncodingwas removed from tokenizer.c but the corresponding declaration in the header file survived. PR removes it.