Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-35647: Fix path check in cookiejar (GH-11436) #12277

Merged
merged 1 commit into from Mar 16, 2019
Merged

[3.5] bpo-35647: Fix path check in cookiejar (GH-11436) #12277

merged 1 commit into from Mar 16, 2019
+38 −5

Conversation

@tirkarthi
Copy link
Contributor

tirkarthi commented Mar 11, 2019 •
edited by bedevere-bot

Refactor cookie path check as per RFC 6265

(cherry picked from commit 0e1f1f0)

https://bugs.python.org/issue35647
@tirkarthi
bpo-35647: Fix path check in cookiejar (#11436)
Loading status checks…
d499320 
* Refactor cookie path check as per RFC 6265

* Add tests for prefix match of path

* Add news entry

* Fix set_ok_path and refactor tests

* Use slice for last letter

(cherry picked from commit 0e1f1f0)
@larryhastings larryhastings merged commit 382981b into python:3.5 Mar 16, 2019
5 checks passed
5 checks passed
bedevere/issue-number Issue number 35647 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Mar 16, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Mar 16, 2019

Thanks for the backport!
@tirkarthi tirkarthi deleted the tirkarthi:backport-0e1f1f0-3.5 branch Mar 23, 2019
@tirkarthi tirkarthi restored the tirkarthi:backport-0e1f1f0-3.5 branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed type-security
Projects
None yet
Milestone
No milestone
4 participants
@tirkarthi @bedevere-bot @larryhastings @the-knights-who-say-ni
You can’t perform that action at this time.