Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER define #10503

Merged
merged 1 commit into from Nov 13, 2018

Conversation

@gpshead
Copy link
Member

commented Nov 13, 2018 •
edited by bedevere-bot

Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P

https://bugs.python.org/issue35214
@gpshead
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
Loading status checks…
567e981

@gpshead gpshead added needs backport to 3.6 skip news needs backport to 3.7 labels Nov 13, 2018

@gpshead gpshead self-assigned this Nov 13, 2018

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 13, 2018

@bedevere-bot bedevere-bot added the awaiting merge label Nov 13, 2018

@gpshead gpshead merged commit 3015fb8 into python:master Nov 13, 2018
4 of 5 checks passed

4 of 5 checks passed

Azure Pipelines PR in progress
Details
bedevere/issue-number Issue number 35214 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 13, 2018

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Nov 13, 2018

@gpshead gpshead deleted the gpshead:msan_Py_prefix branch Nov 13, 2018

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Nov 13, 2018

@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 13, 2018

GH-10504 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 13, 2018
@gpshead @miss-islington
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (pythonGH-10503) 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
9daeb64
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 13, 2018

GH-10505 is a backport of this pull request to the 3.6 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Nov 13, 2018

miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 13, 2018
@gpshead @miss-islington
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (pythonGH-10503) 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
150c4f9
miss-islington added a commit that referenced this pull request Nov 13, 2018
@miss-islington @gpshead
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503) 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6602f9
miss-islington added a commit that referenced this pull request Nov 13, 2018
@miss-islington @gpshead
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503) 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60cf265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gpshead gpshead

Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@gpshead @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.