Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33012: Fix signatures of METH_NOARGS funstions. #10736

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Reviewers

@rhettinger rhettinger

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni
@serhiy-storchaka
Copy link
Member

commented Nov 27, 2018 •
edited by bedevere-bot

https://bugs.python.org/issue33012

@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 needs backport to 2.7 skip news needs backport to 3.7 labels Nov 27, 2018

@serhiy-storchaka serhiy-storchaka requested a review from rhettinger as a code owner Nov 27, 2018

@bedevere-bot bedevere-bot added the awaiting merge label Nov 27, 2018

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 27, 2018

@serhiy-storchaka serhiy-storchaka merged commit 8152402 into python:master Nov 27, 2018
5 checks passed

5 checks passed

Azure Pipelines PR #20181127.5 succeeded
Details
bedevere/issue-number Issue number 33012 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 27, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Nov 27, 2018

@serhiy-storchaka serhiy-storchaka deleted the serhiy-storchaka:noarg-sig branch Nov 27, 2018

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81524022d0c0df7a41f9b2b2df41e2ebe140e610 3.7

@miss-islington miss-islington assigned serhiy-storchaka Nov 27, 2018

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81524022d0c0df7a41f9b2b2df41e2ebe140e610 3.6
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81524022d0c0df7a41f9b2b2df41e2ebe140e610 2.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 27, 2018

@serhiy-storchaka
[3.7] bpo-33012: Fix signatures of METH_NOARGS funstions. (pythonGH-1… 
…0736).

(cherry picked from commit 8152402)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
0196043
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 27, 2018

GH-10748 is a backport of this pull request to the 3.7 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Nov 27, 2018

serhiy-storchaka added a commit that referenced this pull request Nov 27, 2018

@serhiy-storchaka
bpo-33012: Fix signatures of METH_NOARGS functions. (GH-10736) (GH-10748 
)

(cherry picked from commit 8152402)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ad8ac54

miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 27, 2018

@serhiy-storchaka @miss-islington
bpo-33012: Fix signatures of METH_NOARGS functions. (pythonGH-10736) (p… 
…ythonGH-10748)

(cherry picked from commit 8152402)
(cherry picked from commit ad8ac54)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6e131b8

miss-islington added a commit that referenced this pull request Nov 27, 2018

@miss-islington @serhiy-storchaka
bpo-33012: Fix signatures of METH_NOARGS functions. (GH-10736) (GH-10748 
)

(cherry picked from commit 8152402)
(cherry picked from commit ad8ac54)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5c8bd8

vstinner added a commit to vstinner/cpython that referenced this pull request Dec 1, 2018

@serhiy-storchaka @vstinner
bpo-33012: Fix signatures of METH_NOARGS funstions. (pythonGH-10736)
f6ea37a

@serhiy-storchaka serhiy-storchaka removed needs backport to 2.7 needs backport to 3.6 labels Dec 5, 2018

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.