Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35561: Fix valgrind warnings in selectmodule.c #18060

Merged
merged 1 commit into from Jan 19, 2020
Merged

bpo-35561: Fix valgrind warnings in selectmodule.c #18060

merged 1 commit into from Jan 19, 2020
+8 −0

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Jan 19, 2020 •
edited by bedevere-bot

Update Misc/valgrind-python.supp to suppress the false alarm.

https://bugs.python.org/issue35561
@ZackerySpytz
bpo-35561: Fix valgrind warnings in selectmodule.c
Loading status checks…
ecb79cb 
Update Misc/valgrind-python.supp to suppress the false alarm.
@ZackerySpytz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ZackerySpytz commented Jan 19, 2020

I don't think this needs a news entry.
@ZackerySpytz ZackerySpytz mentioned this pull request Jan 19, 2020
Closed
@corona10 corona10 added the skip news label Jan 19, 2020
@csabella csabella requested a review from vstinner Jan 19, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 19, 2020

I confirm that this PR fix https://bugs.python.org/issue35561

I tested manually that the warning goes away with my test: https://bugs.python.org/issue35561#msg359433
@vstinner vstinner merged commit d8ef644 into python:master Jan 19, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200119.6 succeeded
Details
bedevere/issue-number Issue number 35561 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 19, 2020

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 19, 2020

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 19, 2020
@ZackerySpytz @miss-islington
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (pythonGH…
9a13e66 
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 19, 2020

GH-18070 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 19, 2020
@ZackerySpytz @miss-islington
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (pythonGH…
7550a40 
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 19, 2020

GH-18071 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 19, 2020
@miss-islington @ZackerySpytz
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (GH-18060)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
296383b 
Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jan 19, 2020
@miss-islington @ZackerySpytz
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (GH-18060)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
23793ed 
Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@ZackerySpytz @petdance
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (pythonGH…
7d35e90 
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@ZackerySpytz @petdance
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (pythonGH…
a15f1df 
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@ZackerySpytz @petdance
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (pythonGH…
089b7d9 
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@ZackerySpytz @petdance
bpo-35561: Supress valgrind false alarm on epoll_ctl(event) (pythonGH…
43ecb13 
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@ZackerySpytz @vstinner @miss-islington @bedevere-bot @corona10 @the-knights-who-say-ni
You can’t perform that action at this time.