bpo-30670: Add pp function to the pprint module #11769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sort_dicts to pprint.PrettyPrinter, pprint.pformat and pprint.pprint
added 2 commits
Feb 6, 2019
eamanu
reviewed
Feb 6, 2019
eamanu
reviewed
Feb 6, 2019
eamanu
approved these changes
Feb 6, 2019
eamanu
reviewed
Feb 7, 2019
ewjoachim
approved these changes
Feb 8, 2019
| Added the *sort_dicts* parameter. | ||
|
|
||
|
|
||
| .. function:: pp(object, *args, sort_dicts=False, **kwargs) |
There was a problem hiding this comment.
Would it be worth explicitely saying that this is an alias of pprint() with sort_dict=False ?
There was a problem hiding this comment.
There is already a mention of *args and **kwargs being passed to pprint and sort_dicts=False is in the signature of pp so I don't think it is necessary.
I would like to also like to avoid giving to much details about pp implementation because we may change some things if another data structure of Python changes like dicts did.
There was a problem hiding this comment.
(if we were to do change what this function does, we would also change the doc, but I'm good with that.)
vadmium
reviewed
Feb 11, 2019
|
Thanks @vadmium! |
* Add "pp" to __all__ * Drop mention of alphabetical sorting. It is just plain sorting (i.e. dict with integer keys get sorted as well). * Fix spelling of "parameter"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add sort_dicts to pprint.PrettyPrinter, pprint.pformat and pprint.pprint
https://bugs.python.org/issue30670