➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2020-01-18 17:57 by bittner, last changed 2020-01-20 23:38 by ned.deily. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 18054 | merged | bittner, 2020-01-18 17:57 | |
| PR 18088 | merged | miss-islington, 2020-01-20 23:23 | |
| PR 18089 | merged | miss-islington, 2020-01-20 23:23 | |
| Messages (5) | |||
|---|---|---|---|
| msg360248 - (view) | Author: Peter Bittner (bittner) * | Date: 2020-01-18 17:57 | |
The platform module's documentation mentions 'Linux', 'Windows' and 'Java' explicitly as values for `platform.system()`. https://docs.python.org/3/library/platform.html#platform.system Given the popularity of macOS among developers, this gives the impression that the module won't detect 'Darwin' as a separate system type; developers may suspect this will be identified also as a "Linux-y" system (or so). Hence, 'Darwin' should be mentioned explicitly as one of the possible values. |
|||
| msg360344 - (view) | Author: Ned Deily (ned.deily) *  |
Date: 2020-01-20 23:23 | |
New changeset 8d57a4182f0aa68e16d66dea31ba59e732612b4f by Ned Deily (Peter Bittner) in branch 'master': bpo-39383: Mention Darwin as a potential value for platform.system() (GH-18054) https://github.com/python/cpython/commit/8d57a4182f0aa68e16d66dea31ba59e732612b4f |
|||
| msg360345 - (view) | Author: miss-islington (miss-islington) | Date: 2020-01-20 23:28 | |
New changeset 3da839046359644f286195f5126035e162440af1 by Miss Islington (bot) in branch '3.7': bpo-39383: Mention Darwin as a potential value for platform.system() (GH-18054) https://github.com/python/cpython/commit/3da839046359644f286195f5126035e162440af1 |
|||
| msg360346 - (view) | Author: miss-islington (miss-islington) | Date: 2020-01-20 23:28 | |
New changeset c1964e09421e7ab61179eb4e2691e858a50d70e5 by Miss Islington (bot) in branch '3.8': bpo-39383: Mention Darwin as a potential value for platform.system() (GH-18054) https://github.com/python/cpython/commit/c1964e09421e7ab61179eb4e2691e858a50d70e5 |
|||
| msg360347 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2020-01-20 23:38 | |
Thanks for the PR! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-01-20 23:38:36 | ned.deily | set | status: open -> closed versions: + Python 3.7, Python 3.8 type: enhancement -> messages: + msg360347 resolution: fixed stage: patch review -> resolved |
| 2020-01-20 23:28:47 | miss-islington | set | messages: + msg360346 |
| 2020-01-20 23:28:22 | miss-islington | set | nosy:
+ miss-islington messages: + msg360345 |
| 2020-01-20 23:23:16 | miss-islington | set | pull_requests: + pull_request17481 |
| 2020-01-20 23:23:10 | miss-islington | set | keywords:
+ patch stage: patch review pull_requests: + pull_request17480 |
| 2020-01-20 23:23:00 | ned.deily | set | nosy:
+ ned.deily messages: + msg360344 |
| 2020-01-20 21:57:47 | brett.cannon | set | priority: normal -> low |
| 2020-01-18 17:57:43 | bittner | create | |