Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-18697: Update PyUnicode parameter names #12680
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Apr 4, 2019
bedevere-bot
added
the
awaiting review
label
Apr 4, 2019
|
Do not change C sources. Update only the documentation. Don't forget to update the text following the signature. |
serhiy-storchaka
added
skip news
type-documentation
labels
Apr 6, 2019
This comment has been minimized.
This comment has been minimized.
|
Alright, I'll revert the code changes. Phrasing and discussion on the issue made me think it also wanted the code names unified with the doc names |
csabella
requested a review
from serhiy-storchaka
May 29, 2019
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
Jul 12, 2019
|
Thank you for your contribution, but could you check your PR, because you change some parameters, but the documentation is not updated with these new names. |
bedevere-bot
removed
the
awaiting core review
label
Sep 11, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Sep 11, 2019
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
CraftSpider commentedApr 4, 2019
•
edited by bedevere-bot
Per the linked issue, PyUnicode functions/methods had many different parameter names, this PR aims to unify them. There is still at least one unanswered question on the bug-tracker, but it seemed a good idea to get a PR of the existing fixes started to solicit active comments.
https://bugs.python.org/issue18697