Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the experimental PR file margin #2408

Merged
merged 8 commits into from Mar 17, 2020

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Aug 14, 2019

The experimental PR file margin was used to show/hide inline comments on live code. Since this facility is no longer being developed, there is no reason for the margin to still exist. Having it there unnecessarily loads GitHub assemblies when the editor is used.

What this PR does

  • Remove the EditorComments option
  • Remove all PullRequestFileMargin related files
  • Remove checkbox from experimental options UI
jcansdale and others added 4 commits Aug 14, 2019
This was enabled via the "Show PR comments on editor margin" option.
jcansdale added 2 commits Mar 12, 2020
@jcansdale jcansdale requested a review from daschult Mar 15, 2020
daschult and others added 2 commits Mar 16, 2020
@jcansdale jcansdale merged commit ab1e2b1 into master Mar 17, 2020
2 checks passed
2 checks passed
build
Details
github.VisualStudio #2.11.85+0db9174e27 succeeded
Details
@jcansdale jcansdale deleted the fixes/remove-experimental-PR-file-margin branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.