Be more careful on invalid tokens #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes quite a bit of unnecessary diagnostic noise related to
INVALIDtokens, based on the example given by @MaxGraey :In particular, if an
INVALIDtoken is seen and is part of a surrogate pair, the entire pair will be skipped instead of emitting two diagnostics. Also, the tokenizer now implicitly skips over invalid tokens aiding the parser. There's already a diagnostic anyway. Also fixes a bug in the parser emittingnullon empty type parameter lists, which sometimes resulted in reparsing something that already emitted a diagnostic.In the example above, this now results in 2 errors (invalid character, empty type parameter list) instead of spooky 13.