Fix local confusion in generated implicit setters #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with generated implicit field setters of exported classes as reported in #1101.
What happened there was that the use of
makeReplacewas incorrect in that it obtains temporary locals from the current function's flow, but there is no actual current function, hence no flow, for generated setters. Instead, such a function has exactly two locals, its parameters, of which one became overwritten with the old value due to a duplicate temp being picked, leading to an invalid load.The fix applied here implements custom but otherwise identical replace logic, with a single temp local for the intermediate value.