Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 0571: compiler version matching x86_64 docker image #1210

Merged
merged 3 commits into from Oct 22, 2019

Conversation

@zhaofeng-shu33
Copy link
Contributor

@zhaofeng-shu33 zhaofeng-shu33 commented Oct 19, 2019

Fix #1204

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Oct 19, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@zhaofeng-shu33

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@zhaofeng-shu33
Copy link
Contributor Author

@zhaofeng-shu33 zhaofeng-shu33 commented Oct 21, 2019

CLA has signed

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 21, 2019

@takluyver let me know if this is good to merge.

@takluyver
Copy link
Contributor

@takluyver takluyver commented Oct 21, 2019

I think this paragraph should be expanded to talk about the i686 image as well, now that one has been created. As described in #1204, the x86_64 image has devtoolset 8, while the i686 one has devtoolset 7.

I also wouldn't say 'fully new' - that implies it's the latest version, which I don't think it is. Maybe the key point is that it's a newer compiler toolchain than would have been available when CentOS 6 was released in 2010.

@mayeut and @veblush might be better able to help with this - I'm not closely involved with the docker images.

expanded to talk about the i686 image; fully new -> new
@brettcannon brettcannon merged commit bfb3809 into python:master Oct 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants