Skip to content

/ codeql-cli-binaries

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license #10

Merged
merged 1 commit into from Jan 29, 2020
Merged

Update license #10

merged 1 commit into from Jan 29, 2020

Conversation

@s0
Copy link
Contributor

@s0 s0 commented Jan 16, 2020

Update license following changes to canonical license.
@s0
Update license
a2b3dd7
@s0 s0 requested a review from adityasharad Jan 16, 2020
@hmakholm
Copy link
Contributor

@hmakholm hmakholm commented Jan 16, 2020

This needs a corresponding change in odasa-buildutils/codeql-scripts/LICENSE.md of Semmle/code.
@s0
Copy link
Contributor Author

@s0 s0 commented Jan 16, 2020 •
edited

PR opened there.
@jf205
Copy link
Contributor

@jf205 jf205 commented Jan 17, 2020

It's also used in the help: https://git.semmle.com/Semmle/code/blob/master/documentation/restructuredtext/codeql/snippets/license-note.rst
@felicitymay
Copy link

@felicitymay felicitymay commented Jan 28, 2020

Would it make sense to add a CODEOWNERS file to this repo to ensure that any changes to the license file trigger changes to related files in other repos?
@felicitymay
Copy link

@felicitymay felicitymay commented Jan 28, 2020

Update license following changes to canonical license.

@s0 - where is the canonical license?
@s0
Copy link
Contributor Author

@s0 s0 commented Jan 28, 2020

@felicitymay https://github.com/github/securitylab.github.com/blob/master/securitylab/content/pages/tools/codeql/license.mdx, which is subsequently published to https://securitylab.github.com/tools/codeql/license (and linked to from a number of places)
@felicitymay
Copy link

@felicitymay felicitymay commented Jan 29, 2020

See: https://git.semmle.com/Semmle/code/pull/36025 for the change to the license in the CodeQL CLI itself.
@felicitymay
Copy link

@felicitymay felicitymay commented Jan 29, 2020

Given that this change has already been merged into the Security Lab and Code repositories, it makes sense to merge this too. @adityasharad - do you have any objections?
@adityasharad adityasharad merged commit 9c56568 into master Jan 29, 2020
@henrymercer henrymercer deleted the license branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasharad adityasharad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@s0 @hmakholm @jf205 @felicitymay @adityasharad
You can’t perform that action at this time.