Skip to content

/ thefuck

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions in contributing.md don't work, should be replaced with pip3 install . develop #965

Open
jaredgoodman03 opened this issue Oct 6, 2019 · 3 comments
Open

Instructions in contributing.md don't work, should be replaced with pip3 install . develop #965

jaredgoodman03 opened this issue Oct 6, 2019 · 3 comments
Labels
enhancement hacktoberfest help wanted

Comments

@jaredgoodman03
Copy link

@jaredgoodman03 jaredgoodman03 commented Oct 6, 2019

The output of thefuck --version (something like The Fuck 3.1 using Python 3.5.0 and Bash 4.4.12(1)-release):

The Fuck 3.29 using Python 3.6.8 and Bash 4.4.20(1)-release

Your system (Debian 7, ArchLinux, Windows, etc.):

Linux Mint 19.2 Tina

How to reproduce the bug:
Running python3 setup.py develop as explained in CONTRIBUTING.md doesn't actually install the development version on the system. I found better luck by running sudo pip3 install . develop in the root directory of the project. Also, this needed to be changed.

Anything else you think is relevant:

Should I change CONTRIBUTING.md to reflect this and submit a PR, or is this just something wacky on my machine?
@scorphus

This comment has been minimized.

Sign in to view
Copy link
Collaborator

@scorphus scorphus commented Oct 6, 2019

That's great you wish to contribute! Did you try with a virtual environment activated?

As with almost any Python development project, a virtual environment is expected to be created and activated first. And that very much depends on how you as a Python developer create and manage virtual environments (pyenv in my case). Something like that could then be a good addition to CONTRIBUTING.md. What you think?
@steaksauce-

This comment has been minimized.

Sign in to view
Copy link

@steaksauce- steaksauce- commented Oct 6, 2019

On some distributions, Python 2.7 is still the default, and thus pip will default to Python 2 version. As @scorphus mentions, you should activate your venv first. If your venv is based on python 3, pip will be the python 3 version istead of 2.
kain88-de added a commit to kain88-de/thefuck that referenced this issue Oct 14, 2019
@kain88-de
Add instructions for virtualenv in CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
bd44723 
Fix:  nvbn#965
@kain88-de kain88-de mentioned this issue Oct 14, 2019
Closed
@scorphus

This comment has been minimized.

Sign in to view
Copy link
Collaborator

@scorphus scorphus commented Oct 15, 2019

Fix on its way in #976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add instructions for virtualenv in CONTRIBUTING.md
3 participants
@jaredgoodman03 @scorphus @steaksauce-
You can’t perform that action at this time.