Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ionic 5 refresher not working inside sidemenu (mobile MD mode) #20832

Closed
michielcrabbe96 opened this issue Mar 20, 2020 · 6 comments
Closed

bug: ionic 5 refresher not working inside sidemenu (mobile MD mode) #20832

michielcrabbe96 opened this issue Mar 20, 2020 · 6 comments
Labels
package: core type: bug
Milestone
5.5.0

Comments

@michielcrabbe96
Copy link

@michielcrabbe96 michielcrabbe96 commented Mar 20, 2020

Bug Report

Ionic version:
[x] 5.x

Current behavior:
I have an ion-refresher implemented inside the ion-content of an ion-menu. When I'm in mobile MD mode the refresher doesn't appear. However when the screen is large enough that the ion-split-pane kicks in and the menu stays visible, then the ion-refresher works.

Expected behavior:
The ion-refresher to appear in mobile MD mode inside a sidemenu.

Steps to reproduce:
In a new ionic (sidemenu) project, put an ion-refresher inside the ion-content of an ion-menu. When you open the menu in a mobile MD context, try to swipe down to trigger the ion-refresher. You will see the ion-refresher doesn't appear.

Related code:
StackBlitz: https://stackblitz.com/edit/ionic-v5-angular-sidemenu-refresher

Ionic info:

Ionic:

   Ionic CLI                     : 6.2.2 (/Users/michiel/.nvm/versions/node/v12.13.0/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.0.5
   @angular-devkit/build-angular : 0.803.25
   @angular-devkit/schematics    : 8.3.25
   @angular/cli                  : 8.3.25
   @ionic/angular-toolkit        : 2.2.0

Utility:

   cordova-res                          : not installed
   native-run (update available: 0.3.0) : 0.2.9

System:

   NodeJS : v12.13.0 (/Users/michiel/.nvm/versions/node/v12.13.0/bin/node)
   npm    : 6.14.2
   OS     : macOS Catalina
@ionitron-bot ionitron-bot bot added the triage label Mar 20, 2020
@ionitron-bot ionitron-bot bot removed the triage label Mar 20, 2020
@telmaco
Copy link

@telmaco telmaco commented Apr 6, 2020

Same here! I thought I was going crazy XD
@hamakiri
Copy link

@hamakiri hamakiri commented May 3, 2020

Any news on this or a workaround?
@maocop
Copy link

@maocop maocop commented May 18, 2020 •
edited

the error continue any help?
@michielcrabbe96
Copy link
Author

@michielcrabbe96 michielcrabbe96 commented May 18, 2020

A possible workaround is to use the iOS refresher version.
<ion-refresher slot="fixed" mode="ios" (ionRefresh)="refreshNotifications($event)"> <ion-refresher-content></ion-refresher-content> </ion-refresher>

You'll probably also wanna change the refreshingSpinner attribute on the refresher content.
@liamdebeasi liamdebeasi mentioned this issue Nov 6, 2020
Merged
4 of 13 tasks
@liamdebeasi liamdebeasi added this to the 5.5.0 milestone Nov 6, 2020
@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Nov 6, 2020

Thanks for the issue. This has been resolved via #22446, and a fix will be available in an upcoming release of Ionic Framework.
liamdebeasi added a commit that referenced this issue Nov 6, 2020
@liamdebeasi
fix(refresher): refresher gesture now works in side menu (#22446)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6b817f2 
resolves #20832
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this issue Nov 13, 2020
@liamdebeasi Takuma Kira
fix(refresher): refresher gesture now works in side menu (ionic-team#…
c113080 
…22446)

resolves ionic-team#20832
@ionitron-bot
Copy link

@ionitron-bot ionitron-bot bot commented Dec 6, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core type: bug
Projects
None yet
Milestone
5.5.0
Linked pull requests

Successfully merging a pull request may close this issue.

fix(refresher): refresher gesture now works in side menu
5 participants
@liamdebeasi @telmaco @hamakiri @maocop @michielcrabbe96