Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 597: Raise a warning when encoding is omitted #19481

Draft
wants to merge 11 commits into
base: master
from
Draft

PEP 597: Raise a warning when encoding is omitted #19481

wants to merge 11 commits into from
+394 −210

Conversation

@methane
Copy link
Member

@methane methane commented Apr 12, 2020 •
edited

The warning is raised only in dev mode.

pathlib uses the new io.text_encoding helper function.
Other libraries will follow.

Discussion: https://discuss.python.org/t/pep-597-raise-a-warning-when-encoding-is-omitted-in-dev-mode/3880
@methane
Raise a warning when encoding is omitted
Loading status checks…
1059fae 
The warning is raised only in dev mode.

pathlib uses the new `io.text_encoding` helper function.
Other libraries will follow.
@methane methane force-pushed the methane:open-encoding branch from 1ab7ccc to 1059fae Apr 12, 2020
methane added 3 commits Apr 12, 2020
@methane
add test
Loading status checks…
e04344d
@methane
wrap encoding=None with text_encoding.
Loading status checks…
6eb658f
@methane
Fix tests
Loading status checks…
b927e80
@methane methane force-pushed the methane:open-encoding branch from 2b464c8 to b927e80 Apr 12, 2020
@methane
fix test_io
Loading status checks…
e83e9ab
@methane methane force-pushed the methane:open-encoding branch from c7c80aa to c37295e Apr 13, 2020
methane added 2 commits Apr 13, 2020
@methane
fix some tests
647489d
@methane
Fix logging
Loading status checks…
6f72b38
@methane methane force-pushed the methane:open-encoding branch from c37295e to 6f72b38 Apr 13, 2020
methane added 4 commits Apr 13, 2020
@methane
fix test_lzma
Loading status checks…
b511da6
@methane
fix test_lzma
Loading status checks…
e59274d
@methane
Merge remote-tracking branch 'origin/master' into open-encoding
4b478e9
@methane
Use _Py_GetConfig().
Loading status checks…
e44dc5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed DO-NOT-MERGE awaiting core review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@methane @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.