Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39481: Generic alias to os.DirEntry #19415

Merged
merged 1 commit into from Apr 7, 2020

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Apr 7, 2020

Add generic alias to DirEntry

https://bugs.python.org/issue39481

Copy link
Member

@gvanrossum gvanrossum left a comment

LG, but I don't know why the tests are failing.

@isidentical
Copy link
Sponsor Member Author

isidentical commented Apr 7, 2020

This is a known failure

@gvanrossum
Copy link
Member

gvanrossum commented Apr 7, 2020

Dang. Azure does not seem to be a happy place. I guess you could try closing and reopening the PR to retry the tests, hopefully then they'll work so we can merge.

@isidentical isidentical closed this Apr 7, 2020
@isidentical isidentical reopened this Apr 7, 2020
@isidentical
Copy link
Sponsor Member Author

isidentical commented Apr 7, 2020

@gvanrossum ready to go

@gvanrossum gvanrossum merged commit f9dd51e into python:master Apr 7, 2020
@gvanrossum
Copy link
Member

gvanrossum commented Apr 7, 2020

Here you go! If you want to do more, please coordinate with @ethanhs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants