Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jekyll.gitignore #2540

Merged
merged 1 commit into from Dec 5, 2017
Merged

Update Jekyll.gitignore #2540

merged 1 commit into from Dec 5, 2017

Conversation

@tasken
Copy link
Contributor

@tasken tasken commented Dec 5, 2017

Reasons for making this change:

Add .jekyll-cache/ as per https://github.com/envygeeks/jekyll-assets

Links to documentation supporting these rule changes:

Add .jekyll-cache/ as per envygeeks/jekyll-assets
@tasken
Copy link
Contributor Author

@tasken tasken commented Dec 5, 2017

If github/pages-gem#189 is applied, this change will be neccesary

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Dec 5, 2017

@tasken this seems like a pretty safe change irrespective of the linked issue. Thanks!

@shiftkey shiftkey merged commit ea2aa40 into github:master Dec 5, 2017
@jayvdb jayvdb mentioned this pull request Jun 18, 2018
1 of 5 tasks complete
dellagustin added a commit to dellagustin/innersourcecommons.org that referenced this pull request Feb 21, 2020
While implementing the docker support for development environment
setup
(InnerSourceCommons#91)
I noticed that the `.jekyll-cache` folder was created, and this folder
was not on `.gitignore`.
I could not find documentation about it, but some references that it
should be excluded form git:
-
github/gitignore@ea2aa40#diff-3b5726570b981bf3e11c93a6e7bc3ff9
- github/gitignore#2540

It does not seem like content that belongs to the repo, so I
added to the ignore list.
I wonder if other people also have this folder being generated, or
if it is a side-effect of the Docker setup somehow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants