Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40291: Add support for CAN_J1939 sockets #19538

Merged

Conversation

karlding
Copy link
Contributor

@karlding karlding commented Apr 15, 2020

Add support for CAN_J1939 sockets that wrap SAE J1939 protocol
functionality provided by Linux 5.4+ kernels.

https://bugs.python.org/issue40291

Automerge-Triggered-By: @gvanrossum

Add support for CAN_J1939 sockets that wrap SAE J1939 protocol
functionality provided by Linux 5.4+ kernels.
@karlding karlding force-pushed the bpo_40291_add_j1939_socket_support branch from 100fd8d to 7ae7ef5 Compare Apr 19, 2020
@gvanrossum
Copy link
Member

gvanrossum commented Apr 28, 2020

The implementation looks reasonable to me.

Copy link
Member

@gvanrossum gvanrossum left a comment

Looks good.

@gvanrossum gvanrossum added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Apr 29, 2020
@miss-islington miss-islington merged commit 360371f into python:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants