Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented geodesy - Lambert's ellipsoidal distance #1763

Merged
merged 2 commits into from Feb 20, 2020

Conversation

@eightysixth
Copy link
Contributor

eightysixth commented Feb 18, 2020

Describe your change:

Addition of a more accurate algorithm to calculate distances between two points on the Earth's surface. This method treats the Earth as an oblate ellipsoid.

Tests can be cross-referenced here - This is a much more precise algorithm than Lambert's but can be used for comparison.
Insert lat1, lon1 lat2, lon2 into the "Inverse" field and "Calculate" to verify tests. s12 value is the geodesic

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [x ] I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@poyea
poyea approved these changes Feb 20, 2020
Copy link
Member

poyea left a comment

Thank you for your pull request!🤩

Copy link
Member

cclauss left a comment

Nice!

@cclauss cclauss merged commit cb47956 into TheAlgorithms:master Feb 20, 2020
3 checks passed
3 checks passed
codespell
Details
LGTM analysis: Python No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.