Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterative merge sort implementation #1972

Merged
merged 4 commits into from May 11, 2020
Merged

Conversation

@amangupta0709
Copy link
Contributor

amangupta0709 commented May 11, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
sorts/iterative_merge_sort.py Outdated Show resolved Hide resolved
sorts/iterative_merge_sort.py Outdated Show resolved Hide resolved
sorts/iterative_merge_sort.py Outdated Show resolved Hide resolved
sorts/iterative_merge_sort.py Show resolved Hide resolved
sorts/iterative_merge_sort.py Show resolved Hide resolved
sorts/iterative_merge_sort.py Outdated Show resolved Hide resolved
>>> iter_merge_sort([5,9,8,1,2,7])
[1, 2, 5, 7, 8, 9]
>>> iter_merge_sort([6])
[6]
>>> iter_merge_sort([])
[]
>>> iter_merge_sort([-2,-9,-1,-4])
[-9, -4, -2, -1]
Comment on lines 35 to 45

This comment has been minimized.

Copy link
@amangupta0709

amangupta0709 May 11, 2020

Author Contributor

Updated

Suggested change
>>> iter_merge_sort([5,9,8,1,2,7])
[1, 2, 5, 7, 8, 9]
>>> iter_merge_sort([6])
[6]
>>> iter_merge_sort([])
[]
>>> iter_merge_sort([-2,-9,-1,-4])
[-9, -4, -2, -1]
>>> iter_merge_sort([5,9,8,1,2,7])
[1, 2, 5, 7, 8, 9]
>>> iter_merge_sort([6])
[6]
>>> iter_merge_sort([])
[]
>>> iter_merge_sort([-2,-9,-1,-4])
[-9, -4, -2, -1]
@amangupta0709 amangupta0709 requested a review from cclauss May 11, 2020
Copy link
Member

cclauss left a comment

Not very strong on following directions...

@cclauss cclauss merged commit ba8b156 into TheAlgorithms:master May 11, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.