Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file aliquot_sum.py #1985

Merged
merged 10 commits into from May 15, 2020
Merged

Added file aliquot_sum.py #1985

merged 10 commits into from May 15, 2020
+46 −0

Conversation

@ken437
Copy link
Contributor

ken437 commented May 15, 2020

Describe your change:

I added a new algorithm in the maths directory that finds the aliquot sum of a number.
Algorithm explanation: https://en.wikipedia.org/wiki/Aliquot_sum

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [N/A] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
ken437 added 2 commits May 15, 2020
@ken437
Added file aliquot_sum.py containing a function to find theo
4bf73aa
@ken437
Added parameter type info to aliquot_sum.py
Loading status checks…
245369f
@cclauss
cclauss requested changes May 15, 2020
View changes
Copy link
Member

cclauss left a comment

Cool!
maths/aliquot_sum.py Outdated Show resolved Hide resolved
maths/aliquot_sum.py Show resolved Hide resolved
maths/aliquot_sum.py Outdated Show resolved Hide resolved
ken437 and others added 8 commits May 15, 2020
@ken437 @cclauss
Update maths/aliquot_sum.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
05b344f 
Co-authored-by: Christian Clauss <cclauss@me.com>
@ken437 @cclauss
Update maths/aliquot_sum.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e014506 
Co-authored-by: Christian Clauss <cclauss@me.com>
@ken437
Updated code to raise ValueErrors if input is bad
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a8a04df
@ken437
Fixed logical operators
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
357695c
@ken437
Removed unnecessary import
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1e2ba33
@ken437
Updated aliquot_sum.py
Loading status checks…
2a11167
@ken437
fixed formatting
Loading status checks…
eb79bdd
@ken437
fixed documentation
Loading status checks…
366b5e8
@cclauss
cclauss approved these changes May 15, 2020
View changes
Copy link
Member

cclauss left a comment

Well done! Nice contribution. Thanks for doing this.
@cclauss cclauss merged commit a29a2a3 into TheAlgorithms:master May 15, 2020
1 of 2 checks passed
1 of 2 checks passed
codespell
Details
Travis CI - Pull Request Build Started
Details
@ken437
Copy link
Contributor Author

ken437 commented May 15, 2020

Well done! Nice contribution. Thanks for doing this.

You're welcome!
@ken437 ken437 deleted the ken437:aliquot_sum branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ken437 @cclauss
You can’t perform that action at this time.