Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39573: Convert Py_TYPE() to a static inline function #20290

Merged
merged 6 commits into from May 25, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 21, 2020

@corona10 corona10 requested a review from vstinner May 21, 2020
Copy link
Member

@vstinner vstinner left a comment

Oh right, I was waiting for Python 3.10 to do this change.

cc @nascheme

Doc/c-api/structures.rst Show resolved Hide resolved
@corona10
Copy link
Member Author

@corona10 corona10 commented May 22, 2020

@vstinner Updated!

@corona10 corona10 requested a review from vstinner May 22, 2020
Doc/whatsnew/3.10.rst Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/c-api/structures.rst Outdated Show resolved Hide resolved
corona10 and others added 2 commits May 25, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Include/object.h Show resolved Hide resolved
Copy link
Member

@vstinner vstinner left a comment

LGTM. My comments about "const" can be addressed in a separated PR.

Doc/c-api/structures.rst Outdated Show resolved Hide resolved
@corona10 corona10 merged commit ad3252b into python:master May 25, 2020
10 checks passed
tacaswell added a commit to tacaswell/numpy that referenced this issue May 29, 2020
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
tacaswell added a commit to tacaswell/pycurl that referenced this issue May 29, 2020
There was a change in the CPython c-api to change `Py_TYPE` from a
macro to an inline
function (python/cpython#20290).  This
requires a change to using `Py_SET_TYPE` which was introduced on
py39a4.
charris pushed a commit to charris/numpy that referenced this issue May 29, 2020
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants