New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39573: Convert Py_TYPE() to a static inline function #20290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vstinner Updated! |
vstinner
reviewed
May 25, 2020
vstinner
reviewed
May 25, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
May 25, 2020
vstinner
approved these changes
May 25, 2020
LGTM. My comments about "const" can be addressed in a separated PR.
tacaswell
added a commit
to tacaswell/numpy
that referenced
this issue
May 29, 2020
In python/cpython#20290 CPython changed `Py_TYPE` from a macro to an inline function. This requires a code change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue in c code. In python/cpython#20429 CPython changed `Py_SIZE` from a macro to an inline function. This requires a code change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c code.
tacaswell
added a commit
to tacaswell/pycurl
that referenced
this issue
May 29, 2020
There was a change in the CPython c-api to change `Py_TYPE` from a macro to an inline function (python/cpython#20290). This requires a change to using `Py_SET_TYPE` which was introduced on py39a4.
charris
pushed a commit
to charris/numpy
that referenced
this issue
May 29, 2020
In python/cpython#20290 CPython changed `Py_TYPE` from a macro to an inline function. This requires a code change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue in c code. In python/cpython#20429 CPython changed `Py_SIZE` from a macro to an inline function. This requires a code change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c code.
vegerot
pushed a commit
to vegerot/cpython
that referenced
this issue
Jun 10, 2020
vegerot
pushed a commit
to vegerot/cpython
that referenced
this issue
Jun 10, 2020
gmelikov
pushed a commit
to gmelikov/cpython
that referenced
this issue
Aug 22, 2020
chrisburr
pushed a commit
to chrisburr/cpython
that referenced
this issue
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue39573