C#: Remove more deprecated classes and predicates#3514
C#: Remove more deprecated classes and predicates#3514calumgrant merged 1 commit intogithub:masterfrom
Conversation
calumgrant
left a comment
There was a problem hiding this comment.
Overall LGTM. Hard to tell how long these predicates have been deprecated for just from the diff. Also, do we bother with change notes for such things?
hvitved
left a comment
There was a problem hiding this comment.
All removed predicates will have been deprecated at least a year when the next release is made (see comments).
| import semmle.code.csharp.controlflow.ControlFlowGraph | ||
| import ControlFlow | ||
| } | ||
|
|
There was a problem hiding this comment.
Added on 31 Aug 2018: 42faabc#diff-f82a7c7447b81bcc6fd7f5167a7af575R37.
|
|
||
| /** DEPRECATED: Use `getAnnotatedReturnType().isReadonlyRef()` instead. */ | ||
| deprecated predicate returnsRefReadonly() { this.getAnnotatedReturnType().isReadonlyRef() } | ||
|
|
There was a problem hiding this comment.
Added on 19 Jun 2019: d46848e#diff-641704d126764d990302faae6ee9f861R28-R33.
| * Gets the specific class constraint, if any. | ||
| */ | ||
| deprecated Class getClassConstraint() { result = getATypeConstraint() } | ||
|
|
There was a problem hiding this comment.
Added on 25 Jun 2019: abf43da#diff-825fa14ef2ad840d6b646f6cc59d8036R202-R221
|
|
||
| /** Gets a type case of this `switch` statement, if any. */ | ||
| deprecated TypeCase getATypeCase() { result = this.getACase() } | ||
|
|
There was a problem hiding this comment.
Added on 21 May 2019: a1e58ce#diff-d2978c70945820b7e12bee33530ea8b1R181
| */ | ||
| Type getCheckedType() { result = this.getTypeAccess().getType() } | ||
| } | ||
|
|
There was a problem hiding this comment.
Added on 21 May 2019: a1e58ce#diff-d2978c70945820b7e12bee33530ea8b1R316
| } | ||
|
|
||
| /** An `is` type expression, for example, `x is string` or `x is string s`. */ | ||
| deprecated class IsTypeExpr extends IsExpr { |
There was a problem hiding this comment.
Added on 21 May 2019: a1e58ce#diff-e64e0cbcd26fcbd8c1cb0097c21bc50eR425
| } | ||
|
|
||
| /** An `is` pattern expression, for example `x is string s`. */ | ||
| deprecated class IsPatternExpr extends IsExpr { |
There was a problem hiding this comment.
Added on 21 May 2019: a1e58ce#diff-e64e0cbcd26fcbd8c1cb0097c21bc50eR444
| /** | ||
| * An `is` constant expression, for example `x is 5`. | ||
| */ | ||
| deprecated class IsConstantExpr extends IsExpr { |
There was a problem hiding this comment.
Added on 21 May 2019: a1e58ce#diff-e64e0cbcd26fcbd8c1cb0097c21bc50eR471
| deprecated predicate returnsRef() { this.getAnnotatedReturnType().isRef() } | ||
|
|
||
| /** Holds if this delegate returns a `ref readonly`. */ | ||
| deprecated predicate returnsRefReadonly() { this.getAnnotatedReturnType().isReadonlyRef() } |
There was a problem hiding this comment.
Added on 5 Jun 2019: 4aa1947#diff-cd4f5d6b64cc1f53c8880de4018940d0R743-R748
calumgrant
left a comment
There was a problem hiding this comment.
Many thanks for digging up that information @hvitved, it makes the review much easier.
No description provided.