bpo-40453: Add PyConfig._isolated_subinterpreter #19820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An isolated subinterpreter cannot spawn threads, spawn a child process or call os.fork(). * Add private _Py_NewInterpreter(isolated_subinterpreter) function. * Add isolated=True keyword-only parameter to _xxsubinterpreters.create(). * Allow again os.fork() in "non-isolated" subinterpreters.
|
This change is related to https://www.python.org/dev/peps/pep-0554/ PyConfig._isolated_subinterpreter can be used by import to reject C extensions which don't implement multiphase initialization (PEP 489). |
|
@ericsnowcurrently: I chose to aggressively disallow threads and subprocesses. The idea is to only allow them later once we will have more time properly test them once we will have a per-interpreter GIL. |
ericsnowcurrently
approved these changes
May 1, 2020
| @@ -824,7 +825,7 @@ def f(): | |||
| t.join() | |||
| """) | |||
| with file: | |||
| interpreters.run_string(self.id, script) | |||
| interpreters.run_string(subinterp, script) | |||
There was a problem hiding this comment.
It may be worth having a test that assertRaises() when isolated is True. Likewise for the other restrictions.
| @@ -65,6 +65,8 @@ PyAPI_FUNC(int) _Py_CoerceLegacyLocale(int warn); | |||
| PyAPI_FUNC(int) _Py_LegacyLocaleDetected(int warn); | |||
| PyAPI_FUNC(char *) _Py_SetLocaleFromEnv(int category); | |||
|
|
|||
| PyAPI_FUNC(PyThreadState *) _Py_NewInterpreter(int isolated_subinterpreter); | |||
There was a problem hiding this comment.
As we talked about, this is a good place to start. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An isolated subinterpreter cannot spawn threads, spawn a child
process or call os.fork().
_xxsubinterpreters.create().
https://bugs.python.org/issue40453