Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume toolkit from npmjs #12

Merged
merged 1 commit into from Aug 20, 2019
Merged

Consume toolkit from npmjs #12

merged 1 commit into from Aug 20, 2019

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 19, 2019

No description provided.

@damccorm damccorm requested a review from stephenmichaelf Aug 19, 2019
@@ -1,2 +1,2 @@
!node_modules/
__tests__/runner/*
!node_modules/

This comment has been minimized.

@stephenmichaelf

stephenmichaelf Aug 19, 2019
Contributor

Is there a line endings issue?

This comment has been minimized.

@damccorm

damccorm Aug 19, 2019
Author Contributor

Yes, but I think it might actually be the fault of the repo not this PR. I ran git add * --renormalize on all of these PRs, this is the only one that had issues. Renormalize just readds the files with the configuration you have on your machine. In my case, I have core.autocrlf set to true, which means it will get added with LF endings (which is what we want)

@damccorm damccorm merged commit 24b4fa7 into master Aug 20, 2019
2 checks passed
2 checks passed
Run (ubuntu-latest)
Details
Run (windows-latest)
Details
@damccorm damccorm deleted the toolkit branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.