Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM packages #75

Merged
merged 4 commits into from Mar 26, 2020
Merged

Update NPM packages #75

merged 4 commits into from Mar 26, 2020

Conversation

@konradpabjan
Copy link
Collaborator

@konradpabjan konradpabjan commented Mar 25, 2020

Sanity check to make sure everything works before going to master: https://github.com/konradpabjan/Testing2/runs/533477128?check_suite_focus=true

This should make the security warning go away that we're seeing.

I used ncu to update all the packages (haven't found a better way to update all npm packages)
https://stackoverflow.com/questions/16073603/how-do-i-update-each-dependency-in-package-json-to-the-latest-version

Also npm run format-check is green on my windows box, but it's failing here?!? looks like it's just line endings so that can be ignored, still curious as to why (I've got CRLF in vscode and core.autocrlf set to true for git)?

@konradpabjan konradpabjan requested a review from brcrista Mar 25, 2020
@brcrista
Copy link
Collaborator

@brcrista brcrista commented Mar 25, 2020

Why do we need to update all of the packages?

@konradpabjan
Copy link
Collaborator Author

@konradpabjan konradpabjan commented Mar 25, 2020

Why do we need to update all of the packages?

Just going on an update spree. Dependabot has been submitting a few PRs here and there so I figure it's best to keep packages up to date: #73

Also these alerts: https://github.com/actions/setup-python/network/alerts

@brcrista
Copy link
Collaborator

@brcrista brcrista commented Mar 25, 2020

looks like it's just line endings so that can be ignored, still curious as to why (I've got CRLF in vscode and core.autocrlf set to true for git)?

A few tricks here to help:

  • You can see the actual line endings in Notepad++ if you show all characters.
  • With core.autocrlf, you can blow away your working tree (don't delete the .git directory of course) and then git checkout -f konradpabjan/npm-updates to force line ending normalization on all files.
  • To avoid problems in the future, you can add a .gitattributes file at the top level of the repo with the following contents:
* text=auto

.gitattributes will override anyone's local Git config, so we don't have to rely on everyone having the same core.autocrlf settings.

@konradpabjan
Copy link
Collaborator Author

@konradpabjan konradpabjan commented Mar 26, 2020

@brcrista figured it out, * text=auto is needed along with eol=lf. I suspect git might have some different settings during checkout on our runners which is why this weirdness was happening.

I followed the recommendations here: https://prettier.io/docs/en/options.html#end-of-line

@konradpabjan konradpabjan merged commit 4ff1108 into master Mar 26, 2020
5 checks passed
5 checks passed
lint
Details
Run (ubuntu-latest)
Details
Run (ubuntu-latest)
Details
Run (windows-latest)
Details
Run (windows-latest)
Details
@konradpabjan konradpabjan deleted the konradpabjan/npm-updates branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.