Skip to content

/ flask

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing docs are out of date #3545

Open
mattc41190 opened this issue Mar 25, 2020 · 3 comments
Open

Testing docs are out of date #3545

mattc41190 opened this issue Mar 25, 2020 · 3 comments
Labels
docs

Comments

@mattc41190
Copy link
Contributor

@mattc41190 mattc41190 commented Mar 25, 2020 •
edited

The Tutorial section of the docs refers to to the most recent Flaskr application structure however the Testing Deep Dive section is still referring to an application structure from at least the 0.12 version of the tutorial which assumes an application structure that doesn't involve the app factory. This could certainly confuse a new comer... I mean not me.... I certainly wasn't confused by it shifts eyes around nervously

Ref: Ref code snippet here

https://flask.palletsprojects.com/en/1.1.x/testing/#the-testing-skeleton
@devarshigoswami
Copy link

@devarshigoswami devarshigoswami commented Apr 2, 2020

Can I work on this?
@greyli
Copy link
Member

@greyli greyli commented Apr 4, 2020

This issue may related with #2833.

@devarshigoswami Sure, we are happy to review a PR.
@davidism davidism added the docs label Apr 4, 2020
@isdanni isdanni mentioned this issue May 10, 2020
Open
@isdanni
Copy link

@isdanni isdanni commented May 11, 2020

Added a pull request here 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@davidism @mattc41190 @greyli @isdanni @devarshigoswami
You can’t perform that action at this time.