Skip to content

/ python-guide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update virtual environment instructions #1034

Open
wants to merge 3 commits into
base: master
from
Open

update virtual environment instructions #1034

wants to merge 3 commits into from

Conversation

@cs01
Copy link

@cs01 cs01 commented Jan 19, 2020

Now that the venv module is part of the standard library for all non-EOL'd Python versions, the instructions can be simplified to use venv rather than virtualenv.

This PR replaces mentions of virtualenv with venv everywhere but the section that refers users to virtualenv if they are using an older Python version. virtualenv-related tools were removed.
@cs01
simplify virtual environment instructions
Loading status checks…
10afe05
@cs01 cs01 requested a review from dbader Jan 20, 2020
@jhermann
Copy link
Contributor

@jhermann jhermann commented Feb 7, 2020 •
edited

  • Maybe mention the need to still use python3 on many Linux releases.
  • Similarly py -3 -m venv … on Windows.
  • Mention using tox to manage venvs in a project workdir?
@jhermann jhermann mentioned this pull request Feb 7, 2020
Open
@cs01
updates
Loading status checks…
6e200a1
@cs01
Copy link
Author

@cs01 cs01 commented Feb 18, 2020

  • Mentioned python might point to python2
  • Mention py instructions for windows
  • Mention tox, nox, pipx
@jhermann
Copy link
Contributor

@jhermann jhermann commented Feb 18, 2020

--no-site-packages is the default and deprecated for a long time now – actually so long it now disappeared from the newest releases. The --system-site-packages option has to be described instead.
@cs01
add pip-tools; update site-packages info
Loading status checks…
7a54a65
@cs01 cs01 force-pushed the cs01:cs01/venv branch from 5f67198 to 7a54a65 Feb 18, 2020
@cs01
Copy link
Author

@cs01 cs01 commented Mar 14, 2020

This is ready for another review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbader dbader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cs01 @jhermann
You can’t perform that action at this time.