Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_structures/linked_list: Add __len__() function and tests #2047

Merged
merged 15 commits into from May 31, 2020
Merged

data_structures/linked_list: Add __len__() function and tests #2047

merged 15 commits into from May 31, 2020

Conversation

@Lakshmikanth2001
Copy link
Contributor

Lakshmikanth2001 commented May 30, 2020 •
edited

Describe your change:

  • Add an algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Lakshmikanth2001
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
1cd0e54 
please add a function to get length of linked list
@Lakshmikanth2001
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
21d7333
@Lakshmikanth2001
Update doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
dc0c694 
all size function lo doubly linked list class
@Lakshmikanth2001
Merge pull request #2 from Lakshmikanth2001/Lakshmikanth2001-patch-2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6938c58 
Update doubly_linked_list.py
@Lakshmikanth2001
Merge pull request #1 from Lakshmikanth2001/Lakshmikanth2001-patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5300746 
Update __init__.py
@Lakshmikanth2001
prime number _better method
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6a19daf
@Lakshmikanth2001
comments
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
bcafc11
@Lakshmikanth2001
Updated init.py 2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f110e49 
made it more pythonic
@Lakshmikanth2001
updated length function
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
bc75424
@Lakshmikanth2001
commnet in linked_list construtor
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9db0c03
@cclauss
cclauss reviewed May 30, 2020
View changes
data_structures/linked_list/__init__.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed May 30, 2020
View changes
maths/prime_check.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed May 30, 2020
View changes
maths/prime_check.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed May 30, 2020
View changes
data_structures/linked_list/__init__.py Outdated Show resolved Hide resolved
Lakshmikanth2001 and others added 5 commits May 30, 2020
@Lakshmikanth2001 @cclauss
Update data_structures/linked_list/__init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
181ff13 
accepecting changes

Co-authored-by: Christian Clauss <cclauss@me.com>
@Lakshmikanth2001 @cclauss
Update data_structures/linked_list/__init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f683064 
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss
Update __init__.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a08d5c7
@cclauss
Revert changes to doubly_linked_list.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3d25355
@cclauss
Revert changes to prime_check.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
baf6878
@cclauss cclauss changed the title Lakshmikanth2001 patch 3 data_structures/linked_list: Add __len__() function and tests May 31, 2020
@cclauss
cclauss approved these changes May 31, 2020
View changes
Copy link
Member

cclauss left a comment

Thank you for this contribution.
@cclauss cclauss merged commit 321b142 into TheAlgorithms:master May 31, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Lakshmikanth2001 @cclauss
You can’t perform that action at this time.