Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm for checking palindromes #1838

Open
wants to merge 2 commits into
base: master
from
Open

Algorithm for checking palindromes #1838

wants to merge 2 commits into from

Conversation

@joaquincabezas
Copy link
Contributor

joaquincabezas commented Apr 7, 2020

New algorithm for checking palindromes

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
@joaquincabezas
Algorithm for checking palindromes
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d599fc
@cclauss
Copy link
Member

cclauss commented Apr 7, 2020

How is this faster, more efficient, more understandable or in some other way better than the two algorithms in https://github.com/TheAlgorithms/Python/blob/master/other/palindrome.py ?
@TheAlgorithms TheAlgorithms deleted a comment from dukechun Apr 7, 2020
@TheAlgorithms TheAlgorithms deleted a comment from maxs2x Apr 7, 2020
@joaquincabezas
Copy link
Contributor Author

joaquincabezas commented Apr 7, 2020

It adds the "exact_string" parameter which allows to check also phrases like questions (without considering the punctuation or spaces).

Also, the function disregards the lowercase or uppercase differences.
@stale
Copy link

stale bot commented May 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the wontfix label May 7, 2020
@cclauss
A man, a plan, a canal, Panama.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6bd37b3
@stale stale bot removed the wontfix label May 7, 2020
@jntushar
jntushar suggested changes Jun 2, 2020
View changes
Copy link

jntushar left a comment

You're converting input string to lower case
What if user input string like "AbefCZZCfebA" and there is constraint of keeping string as it is.
@cclauss
Copy link
Member

cclauss commented Jun 2, 2020

You can set exact_string https://github.com/TheAlgorithms/Python/pull/1838/files#diff-31603006a040bad9085a346be3ba278aR11
@cclauss cclauss closed this Jun 2, 2020
@cclauss cclauss reopened this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jntushar jntushar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
automated tests are failing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@joaquincabezas @cclauss @jntushar
You can’t perform that action at this time.