Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversions/decimal_to_binary.py: Add type hints #2001

Merged
merged 4 commits into from Jun 2, 2020
Merged

conversions/decimal_to_binary.py: Add type hints #2001

merged 4 commits into from Jun 2, 2020

Conversation

@sarcastic-verma
Copy link
Contributor

sarcastic-verma commented May 18, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@sarcastic-verma
A .py file to covert a base to any new base(2-18)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f047fb2
@sarcastic-verma
Update base_changer.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c8b153
@sarcastic-verma
Added type-hints.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1a7741
@sarcastic-verma
Delete base_changer.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
34895b4
@cclauss cclauss changed the title Add type hints conversions/decimal_to_binary.py: Add type hints May 18, 2020
@cclauss
cclauss reviewed May 18, 2020
View changes
conversions/decimal_to_binary.py
@@ -1,7 +1,7 @@
"""Convert a Decimal Number to a Binary Number."""


def decimal_to_binary(num):
def decimal_to_binary(num: int) -> str:

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss May 18, 2020

Member

It might be even cooler to actually return a binary number. i.e. 0b123 instead of "0b123".
@cclauss
cclauss approved these changes Jun 2, 2020
View changes
@cclauss cclauss merged commit d7cc778 into TheAlgorithms:master Jun 2, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sarcastic-verma @cclauss
You can’t perform that action at this time.