Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harris corner detection #2064

Merged
merged 13 commits into from Jun 4, 2020
Merged

Harris corner detection #2064

merged 13 commits into from Jun 4, 2020
+76 −1

Conversation

@jeffin07
Copy link
Contributor

jeffin07 commented Jun 2, 2020

Describe your change:

Added Harris corner detection. #1809

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
jeffin07 and others added 8 commits Apr 26, 2020
@jeffin07
Added Lstm example for stock predection
Loading status checks…
b49c1f9
@jeffin07
Changes after review
Loading status checks…
ad96d20
@jeffin07
changes after build failed
Loading status checks…
71c045a
@cclauss
Add Kiera’s to requirements.txt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
06a2423
@cclauss
requirements.txt: Add keras and tensorflow
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bdddbd0
@cclauss
psf/black
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c86f555
@jeffin07
haris corner detection
ac8ac85
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
8e50a13
@vicky1999
vicky1999 approved these changes Jun 2, 2020
View changes
Copy link
Contributor

vicky1999 left a comment

Nice work. Thanks for contributing
@cclauss
cclauss requested changes Jun 2, 2020
View changes
computer_vision/harriscorner.py Outdated Show resolved Hide resolved
computer_vision/harriscorner.py Outdated Show resolved Hide resolved
computer_vision/harriscorner.py Outdated Show resolved Hide resolved
computer_vision/harriscorner.py Outdated Show resolved Hide resolved
computer_vision/harriscorner.py Outdated Show resolved Hide resolved
@TheSuperNoob
TheSuperNoob reviewed Jun 3, 2020
View changes
computer_vision/harriscorner.py Show resolved Hide resolved
jeffin07 and others added 5 commits Jun 4, 2020
@jeffin07
changes after review
9c029f9
@jeffin07
lstm pull
2978ba4
@jeffin07
changes after review
10d1a56
@jeffin07
changes after review
Loading status checks…
467b111
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
6e267db
@github-actions github-actions bot force-pushed the jeffin07:hcd branch from 4c99e5d to 6e267db Jun 4, 2020
@jeffin07 jeffin07 requested a review from cclauss Jun 4, 2020
@cclauss
cclauss approved these changes Jun 4, 2020
View changes
Copy link
Member

cclauss left a comment

Looks good to me. Thanks for your contribution.
@cclauss cclauss merged commit 7a14285 into TheAlgorithms:master Jun 4, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@cclauss
Copy link
Member

cclauss commented Jun 4, 2020

I was a bit too fast in merging this. Do we really need a whole new directory for computer vision? Couldn't this instead fit somewhere in
https://github.com/TheAlgorithms/Python/tree/master/digital_image_processing ?
@jeffin07
Copy link
Contributor Author

jeffin07 commented Jun 4, 2020

I think Image processing and computer vision and little different from each other.Image processing means applying some algorithms for transforming image from one form to other like smoothing,contrasting, stretching etc While in computer vision comes from modelling image processing using the techniques of machine learning.Computer vision applies machine learning to recognize patterns for interpretation of images. Much like the process of visual reasoning of human vision
@jeffin07 jeffin07 deleted the jeffin07:hcd branch Jun 4, 2020
@poyea
Copy link
Member

poyea commented Jun 4, 2020

That's great. Feel free to open an issue, or create a readme inside the folder for description, just like the one in /bit_manipulation/.
@jeffin07
Copy link
Contributor Author

jeffin07 commented Jun 4, 2020

@poyea okay great. @cclauss what do you think ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSuperNoob TheSuperNoob

@cclauss cclauss

@vicky1999 vicky1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jeffin07 @cclauss @poyea @TheSuperNoob @vicky1999
You can’t perform that action at this time.