Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euclidean recursive method + doctests + type hints #1999

Merged
merged 3 commits into from May 25, 2020
Merged

Euclidean recursive method + doctests + type hints #1999

merged 3 commits into from May 25, 2020

Conversation

@mateuszz0000
Copy link
Member

mateuszz0000 commented May 18, 2020

Describe your change:

Added recursive method for Euclidean algorithm.
Added doctests and type hints for existing implementation.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@mateuszz0000
Recursive euclidean algorithm + doctests and type hints
20015e1
@mateuszz0000
Fix doctests in recursive method
Loading status checks…
5840532
@cclauss
cclauss requested changes May 18, 2020
View changes
other/euclidean_gcd.py Outdated Show resolved Hide resolved
other/euclidean_gcd.py Outdated Show resolved Hide resolved
other/euclidean_gcd.py Outdated Show resolved Hide resolved
@mateuszz0000
Added commit suggestions
Loading status checks…
201da14
@mateuszz0000 mateuszz0000 requested a review from cclauss May 19, 2020
@cclauss
cclauss approved these changes May 19, 2020
View changes
@mateuszz0000
Copy link
Member Author

mateuszz0000 commented May 25, 2020

Is something to do more here?
@cclauss cclauss merged commit bb5552e into TheAlgorithms:master May 25, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSuperNoob TheSuperNoob

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mateuszz0000 @cclauss @TheSuperNoob
You can’t perform that action at this time.