JS: Track functions through props and returns#3639
Closed
asgerf wants to merge 2 commits into
Closed
Conversation
2 tasks
esbena
approved these changes
Jun 8, 2020
Contributor
Author
|
It doesn't quite scale on gecko, and tweaking the join order doesn't seem to be resolve the issue. I'll close and try something less ambitious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/github/codeql-javascript-team/issues/18 by tracking functions through properties and returns, but not into calls (to avoid FPs from callbacks).
We avoid tracking anything that's a class member as those are tracked via the class instead. We also omit functions in externs for purely speculated performance reasons.
Evaluations:
TODO