Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference why to exclude binary jar, fixes #111 #3154

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Aug 20, 2019

Reasons for making this change:

Improve documentation

Links to documentation supporting these rule changes:

https://github.com/takari/maven-wrapper#usage-without-binary-jar

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Aug 20, 2019

@fulldecent thanks!

@shiftkey shiftkey merged commit 6651bca into github:master Aug 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fulldecent fulldecent deleted the fulldecent:patch-1 branch Aug 21, 2019
tokuhira added a commit to tokuhira/gitignore that referenced this pull request Aug 21, 2019
SaifurRahmanMohsin added a commit to SaifurRahmanMohsin/gitignore that referenced this pull request Aug 29, 2019
* upstream/master:
  Added Simulink cache files (github#3148)
  Add esp-idf.gitignore (github#3150)
  Add *.sch-bak to KiCad.gitignore (github#3153)
  Reference why to exclude binary jar, fixes github#111 (github#3154)
  Update Autotools.gitignore (github#3005)
  Improving the documentation of Objective-C and Swift files (github#3133)
  Ignore gummi previews (github#3144)
  Swift: ignore .swiftpm (github#3083)
  Update Godot.gitignore (github#3142)
  Revert of github#2988. TextMesh Pro files are not auto managed (github#3134)
  Partial revert of 837181e (github#3132)
  Added more glossaries auxiliary files and makeindex logs to TeX template (github#3104)
  .travis.yml: Trim trailing whitespace and indent (github#3118)
  Add *.hie to Haskell.gitignore (github#3120)
  Ignore the .ionide working folder (github#3108)
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants