Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Boruvka's MST algorithm #2026

Merged
merged 14 commits into from May 25, 2020
Merged

added Boruvka's MST algorithm #2026

merged 14 commits into from May 25, 2020

Conversation

@nitishabharathi
Copy link
Contributor

nitishabharathi commented May 22, 2020 •
edited by cclauss

Describe your change:

Added Boruvka's Minimum Spanning Tree Algorithm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@nitishabharathi
added Boruvka's MST algorithm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa0903f
@poyea
poyea requested changes May 22, 2020
View changes
Copy link
Member

poyea left a comment

Thank you for the code! Could you please also add some doctests and typing for your functions and classes, as stated in the CONTRIBUTION.md? It seems that the build failure can be fixed by enabling GitHub Actions in your fork setting.
nitishabharathi and others added 2 commits May 22, 2020
@nitishabharathi
Add files via upload
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
997ae38
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
a5d1c92
@github-actions github-actions bot force-pushed the nitishabharathi:master branch from decbcf8 to a5d1c92 May 22, 2020
@poyea
Copy link
Member

poyea commented May 22, 2020

The build is failing because of exceptions and failing tests. Add more commits to your branch to fix them.
nitishabharathi and others added 2 commits May 22, 2020
@nitishabharathi
Updated Boruvka with doctest
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7c1e415
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
fcb9f61
@cclauss
Update minimum_spanning_tree_boruvka.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c72d3e
@Abhiram010
Copy link

Abhiram010 commented May 25, 2020

Please check my small code my respiratory "My time saver" give a hand to raise new programmer it completely written with if you can just execute and check
cclauss added 3 commits May 25, 2020
@cclauss
No blank line in doctest
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e7d4b8
@cclauss
<BLANKLINE>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
87e661c
@cclauss
Avoid mutable default values
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c08c697 
https://docs.python-guide.org/writing/gotchas/
@cclauss
Copy link
Member

cclauss commented May 25, 2020

Avoid mutable default values https://docs.python-guide.org/writing/gotchas/
@cclauss
Update minimum_spanning_tree_boruvka.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
042f2c5
@github-actions github-actions bot force-pushed the nitishabharathi:master branch from 719c791 to 042f2c5 May 25, 2020
cclauss and others added 4 commits May 25, 2020
@cclauss
Avoid mutable default values
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e55384
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
2610ada
@cclauss
Update minimum_spanning_tree_boruvka.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
531665f
@nitishabharathi
Update minimum_spanning_tree_boruvka.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
00eea57
@cclauss
cclauss approved these changes May 25, 2020
View changes
@nitishabharathi nitishabharathi requested a review from poyea May 25, 2020
@poyea
poyea approved these changes May 25, 2020
View changes
Copy link
Member

poyea left a comment

Thank you for your pull request!🤩
@cclauss cclauss merged commit 0e61906 into TheAlgorithms:master May 25, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@poyea poyea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nitishabharathi @poyea @Abhiram010 @cclauss
You can’t perform that action at this time.