Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40636: Documentation for zip-strict #20961

Merged
merged 7 commits into from Jun 19, 2020
Merged

bpo-40636: Documentation for zip-strict #20961

merged 7 commits into from Jun 19, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 18, 2020 •
edited by bedevere-bot

@brandtbucher @vstinner @gvanrossum

This is the documentation for the zip-strict feature implemented in #20921 .

When reviewing this PR, I suggest that you look at it in the HTML view.

Also, can someone put the skip-news tag here? There's a news item in the other PR.

https://bugs.python.org/issue40636

@cool-RR cool-RR marked this pull request as ready for review Jun 18, 2020
@bedevere-bot bedevere-bot added docs awaiting review labels Jun 18, 2020
@cool-RR cool-RR force-pushed the 2020-06-18-zip-strict-docs branch 2 times, most recently from 709b0b4 to 8dc14f5 Compare Jun 18, 2020
@cool-RR
Copy link
Author

@cool-RR cool-RR commented Jun 18, 2020

Please ignore the docs CI failure here, it's because the feature is implemented in a separate PR.

gvanrossum
gvanrossum reviewed Jun 18, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Thanks for this first draft! I ran out of time to review the three big bullets more carefully, but I have saved up some feedback that I hope you will take into account.

Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher reviewed Jun 18, 2020
View changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher reviewed Jun 18, 2020
View changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher reviewed Jun 18, 2020
View changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher reviewed Jun 18, 2020
View changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher reviewed Jun 18, 2020
View changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher reviewed Jun 18, 2020
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
brandtbucher
brandtbucher requested changes Jun 18, 2020
View changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Thanks! I left some comments too.

@cool-RR cool-RR force-pushed the 2020-06-18-zip-strict-docs branch 2 times, most recently from 10cc1c6 to 06408a4 Compare Jun 18, 2020
brandtbucher
brandtbucher requested changes Jun 18, 2020
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
gvanrossum
gvanrossum reviewed Jun 19, 2020
View changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Show resolved Hide resolved
Doc/library/functions.rst Show resolved Hide resolved
brandtbucher
brandtbucher requested changes Jun 19, 2020
View changes
Copy link
Member

@brandtbucher brandtbucher left a comment •
edited

Looks good, after you apply Guido's feedback. Just one more tiny thing I noticed (not a big deal):

Doc/library/functions.rst Show resolved Hide resolved
gvanrossum
gvanrossum approved these changes Jun 19, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

LGTM. I'll merge next. Thanks for doing this extensive update!

Doc/library/functions.rst Show resolved Hide resolved
Doc/library/functions.rst Show resolved Hide resolved
@gvanrossum
Copy link

@gvanrossum gvanrossum commented Jun 19, 2020

Hm, I can't merge because of the failing test. @cool-RR can you merge the latest master now that the implementation has been merged?

@brandtbucher
Copy link

@brandtbucher brandtbucher commented Jun 19, 2020

Thanks @cool-RR!

cool-RR and others added 4 commits Jun 19, 2020
@cool-RR cool-RR force-pushed the 2020-06-18-zip-strict-docs branch from f21ad5b to a67f52a Compare Jun 19, 2020
@cool-RR
Copy link
Author

@cool-RR cool-RR commented Jun 19, 2020

Rebased and pushed, let's see whether tests pass. I haven't squashed the commits, I assume the GitHub interface lets you do that. If you want me to squash, let me know.

@gvanrossum gvanrossum merged commit 59cf853 into python:master Jun 19, 2020
10 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 19, 2020

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@gvanrossum
Copy link

@gvanrossum gvanrossum commented Jun 19, 2020 •
edited

Congrats, and thanks! Looking forward to more of your work.

@cool-RR
Copy link
Author

@cool-RR cool-RR commented Jun 19, 2020

😊

Do you want a PR to the Python 3.10 release schedule?

@gvanrossum
Copy link

@gvanrossum gvanrossum commented Jun 19, 2020

@cool-RR
Copy link
Author

@cool-RR cool-RR commented Jun 19, 2020

I checked for PEPs with the string "Python-Version: 3.10" and besides 618, there isn't a single one that has "Status: Accepted", so I guess not.

fasih pushed a commit to fasih/cpython that referenced this issue Jun 29, 2020
@cool-RR @fasihahmad
bpo-40636: Documentation for zip-strict (python#20961)
36ba8ab
J-Arun-Mani pushed a commit to J-Arun-Mani/cpython that referenced this issue Jul 21, 2020
@cool-RR @J-Arun-Mani
bpo-40636: Documentation for zip-strict (python#20961)
47144e9
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@cool-RR @chrisburr
bpo-40636: Documentation for zip-strict (python#20961)
58a411f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed docs skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cool-RR @gvanrossum @brandtbucher @bedevere-bot @the-knights-who-say-ni