bpo-41025: Fix subclassing for zoneinfo.ZoneInfo #20965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48ed5b8 to
d03b88a
Compare
|
Will this make it to the 3.9.0 final release? |
Member
Author
|
Yes, I was just waiting for a review. |
Prior to this change, attempting to subclass the C implementation of
zoneinfo.ZoneInfo gave the following error:
TypeError: unbound method ZoneInfo.__init_subclass__() needs an argument
https://bugs.python.org/issue41025
d03b88a to
4afb655
Compare
Member
Author
|
We may need to ask @ambv to explicitly backport it at this point, which I think would be appropriate. I didn't realize that after rc1 the I think this is important enough to get backported. Wish I had remembered earlier that this PR was still open. |
Contributor
|
Thanks @pganssle for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 14, 2020
Prior to this change, attempting to subclass the C implementation of
zoneinfo.ZoneInfo gave the following error:
TypeError: unbound method ZoneInfo.__init_subclass__() needs an argument
https://bugs.python.org/issue41025
(cherry picked from commit 87d8287)
Co-authored-by: Paul Ganssle <paul@ganssle.io>
|
GH-21876 is a backport of this pull request to the 3.9 branch. |
pganssle
added a commit
that referenced
this pull request
Aug 14, 2020
Prior to this change, attempting to subclass the C implementation of
zoneinfo.ZoneInfo gave the following error:
TypeError: unbound method ZoneInfo.__init_subclass__() needs an argument
https://bugs.python.org/issue41025
(cherry picked from commit 87d8287)
Co-authored-by: Paul Ganssle <paul@ganssle.io>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
Prior to this change, attempting to subclass the C implementation of
zoneinfo.ZoneInfo gave the following error:
TypeError: unbound method ZoneInfo.__init_subclass__() needs an argument
https://bugs.python.org/issue41025
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Prior to this change, attempting to subclass the C implementation of
zoneinfo.ZoneInfo gave the following error:
TypeError: unbound method ZoneInfo.__init_subclass__() needs an argument
https://bugs.python.org/issue41025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, attempting to subclass the C implementation of
zoneinfo.ZoneInfogave the following error:CC: @sdispater
https://bugs.python.org/issue41025
Automerge-Triggered-By: @pganssle