bpo-37630: Do not skip the sha3 tests in case of missing builtin sha3 module #20986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Since we can use now the sha3 and shake algorithms from OpenSSL, we shouldn't skip the tests in case the builtin algorithm was not compiled or removed.
Contributor
Author
|
This is a tests only change, so no news entry is added. |
Contributor
Author
|
Already tested on the RHEL 8 FIPS buildbot and by using the --without-builtin-hashlib-hashes configure option. The tests are not skipped anymore. |
tiran
approved these changes
Apr 17, 2021
Member
tiran
left a comment
There was a problem hiding this comment.
Thanks! Python 3.10 now requires OpenSSL 1.1.1 which comes with sha3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can use now the sha3 and shake algorithms from OpenSSL, we shouldn't
skip the tests in case the builtin algorithm was not compiled or removed.
https://bugs.python.org/issue37630
Automerge-Triggered-By: GH:tiran